linux-kernel - Re: [PATCH v2 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Aug 2013 00:21:59 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Heiko Stübner <heiko@...ech.de>,
	Kukjin Kim <kgene.kim@...sung.com>, Dan Williams <djbw@...com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Sylwester Nawrocki <sylvester.nawrocki@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

On Mon, Aug 19, 2013 at 6:48 AM, Vinod Koul <vinod.koul@...el.com> wrote:
> On Wed, Aug 14, 2013 at 02:00:25PM +0200, Heiko Stübner wrote:

>> Conceptually the s3c24xx-dma feels like a distant relative of the pl08x
>> with numerous virtual channels being mapped to a lot less physical ones.
>> The driver therefore borrows a lot from the amba-pl08x driver in this
>> regard. Functionality-wise the driver gains a memcpy ability in addition
>> to the slave_sg one.
>
> If that is the case why cant we have this driver supported from pl08x driver? If
> the delta is only mapping then can that be seprated or both mapping hanlded?
> Maybe you and Linus have already though about that?

I took a look at the register list and couldn't find a way to save code
by trying to shoehorn it into the PL08x, the registers and bit layouts are
totally different. IIRC this driver does not
have LLIs either so it's quite different and would look strange.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/