linux-kernel - Re: [PATCH 05/13] ARM: ux500: Apply a ste-* prefix onto snowball.dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMgZYFgwAhVCc-ObnxcmGTLTM-Zk27Dh7r1_p646ULWHeg@mail.gmail.com>
Date:	Wed, 21 Aug 2013 16:22:26 -0700
From:	Olof Johansson <olof@...om.net>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Lee Jones <lee.jones@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...ricsson.com>
Subject: Re: [PATCH 05/13] ARM: ux500: Apply a ste-* prefix onto snowball.dts

On Wed, Aug 21, 2013 at 3:37 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Wed, Aug 21, 2013 at 2:31 AM, Olof Johansson <olof@...om.net> wrote:
>
>>> diff --git a/arch/arm/boot/dts/snowball.dts b/arch/arm/boot/dts/ste-snowball.dts
>>> similarity index 100%
>>> rename from arch/arm/boot/dts/snowball.dts
>>> rename to arch/arm/boot/dts/ste-snowball.dts
>>
>> Grmbl, grmbl, grmbl. This now breaks any script that knows to use
>> snowball.dtb. :(
>>
>> It's good to get the prefixes added, but it's annoying to have to deal
>> with both during an overlap period. Maybe generate both dtb filenames
>> for a while but rename the source?
>
> Hm I had the same problem but changed my Makefile
> (scripts are too simple for me) like this:
>
>  dtb            := $(build_dir)/arch/arm/boot/dts/ste-hrefv60plus.dtb
> +fallbackdtb    := $(build_dir)/arch/arm/boot/dts/hrefv60plus.dtb
> (...)
> -       cat $(dtb) >> $(output_dir)/zImage
> +       if [ -f arch/arm/boot/dts/hrefv60plus.dts ] ; then \
> +           cat $(fallbackdtb) >> $(output_dir)/zImage ; echo "fallback" ; \
> +       else \
> +           cat $(dtb) >> $(output_dir)/zImage ; \
> +       fi

Sure, working around it is trivial. I just did a:
   -@cp $</arch/arm/boot/dts/ste-snowball.dtb $</arch/arm/boot/dts/snowball.dtb

But the point is that everybody needs to do something like that now,
which is unfortunate.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/