linux-kernel - Re: [PATCH] documentation/devicetree: Move DT bindigns from gpio to watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130822073740.GA3717@jtlinux>
Date:	Thu, 22 Aug 2013 09:37:42 +0200
From:	Johannes Thumshirn <johannes.thumshirn@....de>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	Johannes Thumshirn <johannes.thumshirn@....de>,
	Rob Landley <rob@...dley.net>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ian.campbell@...rix.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Guenter Roeck <linux@...ck-us.net>,
	<devicetree@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-watchdog@...r.kernel.org>
Subject: Re: [PATCH] documentation/devicetree: Move DT bindigns from gpio to
 watchdog

On Wed, Aug 21, 2013 at 11:34:00AM -0600, Stephen Warren wrote:
> On 08/21/2013 06:42 AM, Johannes Thumshirn wrote:
> > I accidently put the devicetree bindings for the MEN A21 watchdog driver in
> > Documentation/devicetree/bindings/gpio instead of
> > Documentation/devicetree/bindings/watchdog, this patch addresses this error.
>
> The rename sounds fine, so that part,
> Acked-by: Stephen Warren <swarren@...dia.com>
>
> However, the binding itself doesn't look right; it appears to have a
> single "gpios" property rather than using separate named xxx-gpios
> properties for different things...

Ok, so I'll need something like the following?

watchdog {
	compatible ="men,a021-wdt";
	enable-gpios = <&gpio3 9 1>; /* WD_EN */
	fast-gpios = <&gpio3 10 1>;  /* WD_FAST */
	trig-gpios = <&gpio3 11 1>;  /* WD_TRIG */
	rst0-gpio = <&gpio3 6 1>;    /* RST_CAUSE[0] */
	rst1-gpio = <&gpio3 7 1>;    /* RST_CAUSE[1] */
	rst2-gpio = <&gpio3 8 1>;    /* RST_CAUSE[2] */
};

Or is there something like of_get_named_gpios(...) so I can put all 3 rst-gpios
into one property? A quick grep only revealed of_get_named_gpio(...).

Thanks,
Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/