lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Aug 2013 15:50:38 +0800 From: Li Zhong <zhong@...ux.vnet.ibm.com> To: Rusty Russell <rusty@...tcorp.com.au> Cc: Greg KH <gregkh@...uxfoundation.org>, linux-next list <linux-next@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, rmk+kernel@....linux.org.uk Subject: Re: [RFC PATCH next]module: Fix mod->mkobj.kobj potentially freed too early On Thu, 2013-08-22 at 16:30 +0930, Rusty Russell wrote: > Greg KH <gregkh@...uxfoundation.org> writes: > > On Wed, Aug 21, 2013 at 05:49:58PM +0800, Li Zhong wrote: > > > struct kobj_type module_ktype = { > > > + .release = module_kobj_release, > > > .sysfs_ops = &module_sysfs_ops, > > > }; > > > > Wait, as there is no release function here for the kobject (a different > > problem), why is the deferred release function causing any problems? > > There is no release function to call, so what is causing the oops? > > Because DEBUG_KOBJECT_RELEASE does the kobject_put() sometime later, > which is what causes the oops. > > Since kobjects don't have an owner field, AFAICT someone *could* grab > one in a module which is unloading, then put it after unload. So this > fixes a real bug, albeit not one seen in the real world. > > Applied, Oh, thank you, Rusty. I just sent out another version... which fix it in another way as Greg suggested, could you please also help to take a look at it? Thanks, Zhong > Rusty. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists