linux-kernel - Re: [PATCH] dma: ipu: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130822013145.GG30533@S2101-09.ap.freescale.net>
Date:	Thu, 22 Aug 2013 09:31:47 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Vinod Koul' <vinod.koul@...el.com>, 'Dan Williams' <djbw@...com>,
	<linux-kernel@...r.kernel.org>,
	'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>,
	'Fabio Estevam' <fabio.estevam@...escale.com>
Subject: Re: [PATCH] dma: ipu: remove unnecessary platform_set_drvdata()

On Wed, Aug 21, 2013 at 06:52:54PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Shawn Guo <shawn.guo@...aro.org>

> ---
>  drivers/dma/ipu/ipu_idmac.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 608d4a2..cb9c0bc 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1764,7 +1764,6 @@ static int ipu_remove(struct platform_device *pdev)
>  	iounmap(ipu->reg_ic);
>  	iounmap(ipu->reg_ipu);
>  	tasklet_kill(&ipu->tasklet);
> -	platform_set_drvdata(pdev, NULL);
>  
>  	return 0;
>  }
> -- 
> 1.7.10.4
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/