linux-kernel - Re: [PATCH 01/10] sched: Remove one division operation in find_busiest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130822102508.GG31370@twins.programming.kicks-ass.net>
Date:	Thu, 22 Aug 2013 12:25:08 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Paul Turner <pjt@...gle.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Mike Galbraith <efault@....de>, Alex Shi <alex.shi@...el.com>,
	Preeti U Murthy <preeti@...ux.vnet.ibm.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Morten Rasmussen <morten.rasmussen@....com>,
	Namhyung Kim <namhyung@...nel.org>,
	Lei Wen <leiwen@...vell.com>, Joonsoo Kim <js1304@...il.com>,
	Rik van Riel <riel@...riel.com>
Subject: Re: [PATCH 01/10] sched: Remove one division operation in
 find_busiest_queue()

On Thu, Aug 22, 2013 at 01:58:28AM -0700, Paul Turner wrote:

> >         wl_i / power_i > wl_j / power_j :=
> >         wl_i * power_j > wl_j * power_i
> >
> >         struct rq *busiest = NULL, *rq;
> > -       unsigned long max_load = 0;
> > +       unsigned long busiest_load = 0, busiest_power = SCHED_POWER_SCALE;
> 
> Initializing this to SCHED_POWER_SCALE assigns a meaning that isn't
> really there.  How about just 1?

Right, 1 works, all we really need is for wl to be > 0.

> >         int i;
> >
> >         for_each_cpu(i, sched_group_cpus(group)) {
> > @@ -5049,10 +5049,9 @@ static struct rq *find_busiest_queue(str
> >                  * the load can be moved away from the cpu that is potentially
> >                  * running at a lower capacity.
> >                  */
> > -               wl = (wl * SCHED_POWER_SCALE) / power;
> > -
> > -               if (wl > max_load) {
> > -                       max_load = wl;
> 
> A comment wouldn't hurt here.

Agreed, something like so?

/*
 * Since we're looking for max(wl_i / power_i) crosswise multiplication
 * to rid ourselves of the division works out to:
 * wl_i * power_j > wl_j * power_i;  where j is our previous maximum.
 */

> > +               if (wl * busiest_power > busiest_load * power) {
> > +                       busiest_load = wl;
> > +                       busiest_power = power;
> >                         busiest = rq;
> >                 }
> >         }
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/