linux-kernel - Re: [PATCH] pinctrl: sh-pfc: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Aug 2013 13:04:02 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Jingoo Han <jg1.han@...sung.com>,
	'Simon Horman' <horms@...ge.net.au>
Cc:	'Linus Walleij' <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: sh-pfc: remove unnecessary platform_set_drvdata()

Hi Jingoo,

Thank you for the patch.

On Thursday 22 August 2013 11:00:55 Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Linus, can you take this for v3.12 ? If it's too late I'll take it in my tree 
and will include it in the v3.13 pull request.

> ---
>  drivers/pinctrl/sh-pfc/core.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
> index 9e66614..738f14f 100644
> --- a/drivers/pinctrl/sh-pfc/core.c
> +++ b/drivers/pinctrl/sh-pfc/core.c
> @@ -539,8 +539,6 @@ static int sh_pfc_remove(struct platform_device *pdev)
>  	if (pfc->info->ops && pfc->info->ops->exit)
>  		pfc->info->ops->exit(pfc);
> 
> -	platform_set_drvdata(pdev, NULL);
> -
>  	return 0;
>  }
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/