linux-kernel - Re: [PATCH v1 3/4] spi/xilinx: Simplify irq allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130822131051.GI26118@sirena.org.uk>
Date:	Thu, 22 Aug 2013 14:10:51 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Michal Simek <monstr@...str.eu>
Cc:	Michal Simek <michal.simek@...inx.com>,
	linux-kernel@...r.kernel.org,
	linux-spi <linux-spi@...r.kernel.org>,
	Grant Likely <grant.likely@...aro.org>,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH v1 3/4] spi/xilinx: Simplify irq allocation

On Fri, Jul 12, 2013 at 04:00:24PM +0200, Michal Simek wrote:

> Just a follow up on this.

Sorry, this one fell through the cracks - apologies for the delay.

> Which function free private structures registered by spi_alloc_master function?
> Is it in spi_master_put()?

Yes, or spi_master_unregister() after it's been registered.

> The reason why I am asking is where clk_xx functions should be added.
> I see them between these two functions in sifr for example.

> And also I see in drivers in error probe path that drivers are calling kfree(master)
> but they are not doing in remove part (like spi-davinci.c).

> I just want to clear this in our zynq drivers before we send them out.

I'd not be surprised if there were errors in the error handling paths,
it's (hopefully!) not the best tested code out there.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)