linux-kernel - Re: [PATCH] scsi: fix the build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1377181627.2009.2.camel@dabdike.int.hansenpartnership.com>
Date:	Thu, 22 Aug 2013 14:27:07 +0000
From:	James Bottomley <jbottomley@...allels.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
CC:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Joe Perches <joe@...ches.com>,
	Zhi Yong Wu <zwu.kernel@...il.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	linux-kernel mlist <linux-kernel@...r.kernel.org>,
	Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>,
	"Paul Bolle" <pebolle@...cali.nl>,
	Douglas Gilbert <dgilbert@...erlog.com>
Subject: Re: [PATCH] scsi: fix the build warning

On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote:
> 2013/8/22 Martin K. Petersen <martin.petersen@...cle.com>:
> >>>>>> "Joe" == Joe Perches <joe@...ches.com> writes:
> >
> > Joe> I don't get this build warning in the first place and I think the
> > Joe> scsi_debug file is quite old and probably doesn't need to be
> > Joe> changed at all.
> >
> > guard isn't a boolean, it selects the checksum algorithm used.
> >
> > Also, I believe Akinobu's recent reorganization of this code in question
> > fixed the warning.
> 
> Unfortunately, this warning isn't fixed in linux-next, either.
> Paul Bolle also sent a patch that fixes the same warning in a little
> bit different way.

Well, it is and it isn't.  Whether you see the warning seems to depend
on how gcc was built.  My take is that an impossible default case just
to keep some versions of gcc quiet is a bit pointless.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/