linux-kernel - Re: [PATCH v2 05/10] vfio: use get_unused_fd_flags(0) instead of get_unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1377186804.25163.17.camel@ul30vt.home>
Date:	Thu, 22 Aug 2013 09:53:24 -0600
From:	Alex Williamson <alex.williamson@...hat.com>
To:	Yann Droneaud <ydroneaud@...eya.com>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Alexey Kardashevskiy <aik@...abs.ru>
Subject: Re: [PATCH v2 05/10] vfio: use get_unused_fd_flags(0) instead of
 get_unused_fd()

On Thu, 2013-08-15 at 15:10 +0200, Yann Droneaud wrote:
> Macro get_unused_fd() is used to allocate a file descriptor with
> default flags. Those default flags (0) can be "unsafe":
> O_CLOEXEC must be used by default to not leak file descriptor
> across exec().
> 
> Instead of macro get_unused_fd(), functions anon_inode_getfd()
> or get_unused_fd_flags() should be used with flags given by userspace.
> If not possible, flags should be set to O_CLOEXEC to provide userspace
> with a default safe behavor.
> 
> In a further patch, get_unused_fd() will be removed so that
> new code start using anon_inode_getfd() or get_unused_fd_flags()
> with correct flags.
> 
> This patch replaces calls to get_unused_fd() with equivalent call to
> get_unused_fd_flags(0) to preserve current behavor for existing code.
> 
> The hard coded flag value (0) should be reviewed on a per-subsystem basis,
> and, if possible, set to O_CLOEXEC.
> 
> Signed-off-by: Yann Droneaud <ydroneaud@...eya.com>
> Link: http://lkml.kernel.org/r/cover.1376327678.git.ydroneaud@opteya.com
> 
> ---
>  drivers/vfio/vfio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index d3cb342..75c16cc 100644
> --- a/drivers/vfio/vfio.c
> +++ b/drivers/vfio/vfio.c
> @@ -1109,7 +1109,7 @@ static int vfio_group_get_device_fd(struct vfio_group *group, char *buf)
>  		 * We can't use anon_inode_getfd() because we need to modify
>  		 * the f_mode flags directly to allow more than just ioctls
>  		 */
> -		ret = get_unused_fd();
> +		ret = get_unused_fd_flags(0);
>  		if (ret < 0) {
>  			device->ops->release(device->device_data);
>  			break;

I don't see any reason why we shouldn't be adding O_CLOEXEC here.  If
anyone disagrees, please speak up.  I'll include this in my next tree
and post a follow-on patch to replace 0 with O_CLOEXEC.  Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/