| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Aug 2013 19:29:56 +0200 From: "Jason A. Donenfeld" <Jason@...c4.com> To: Matthew Garrett <mjg59@...f.ucam.org> Cc: linux-acpi@...r.kernel.org, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, mjg@...hat.com, rjw@...k.pl, len.brown@...el.com, dtor@...ightbb.com Subject: Re: [PATCH 3/3] thinkpad_acpi: Wire unused micmute LED to capslock On Thu, Aug 22, 2013 at 5:39 PM, Matthew Garrett <mjg59@...f.ucam.org> wrote: > I think there's a risk of user confusion here, in that it's now possible > for the mic mute light to be lit despite the internal microphone still > being active. That seems like surprising behaviour. Yeah, that is a legitimate concern. Patches 1/3 [1] and 2/3 [2] clearly make sense, as they're generic and don't really suggest any new behavior. But setting this behavior here as the default could indeed be a bit unexpected. I think it's fair to reject this patch (3/3), but accept the first two. Tweakers who have the same early boot caps-lock LED needs as me can simply put this in their initramfs after 1/3 and 2/3 are applied: # echo caps-lock > /sys/devices/platform/thinkpad_acpi/leds/tpacpi\:\:micmute/trigger Jason [1] https://lkml.org/lkml/2013/8/22/310 [2] https://lkml.org/lkml/2013/8/22/313 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists