linux-kernel - Re: [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Aug 2013 09:29:57 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Daniel Lezcano' <daniel.lezcano@...aro.org>,
	'Thomas Gleixner' <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, 'Magnus Damm' <damm@...l.co.jp>,
	'Paul Mundt' <lethal@...ux-sh.org>
Subject: Re: [PATCH 1/2] clocksource: sh_tmu: remove unnecessary
 platform_set_drvdata()

On Wed, Aug 21, 2013 at 06:21:29PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

No objections for this and the following patch:

Acked-by: Simon Horman <horms+renesas@...ge.net.au>

Daniel, let me know if you would prefer if I queued these up
and sent you a pull request or you would rather just pick
them up directly.

> ---
>  drivers/clocksource/sh_tmu.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
> index 78b8dae..54ab475 100644
> --- a/drivers/clocksource/sh_tmu.c
> +++ b/drivers/clocksource/sh_tmu.c
> @@ -509,7 +509,6 @@ static int sh_tmu_probe(struct platform_device *pdev)
>  	ret = sh_tmu_setup(p, pdev);
>  	if (ret) {
>  		kfree(p);
> -		platform_set_drvdata(pdev, NULL);
>  		pm_runtime_idle(&pdev->dev);
>  		return ret;
>  	}
> -- 
> 1.7.10.4
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/