linux-kernel - Re: [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5216798E.8070900@wwwdotorg.org>
Date:	Thu, 22 Aug 2013 14:50:22 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Kishon Vijay Abraham I <kishon@...com>
CC:	bcousson@...libre.com, tony@...mide.com, myungjoo.ham@...sung.com,
	cw00.choi@...sung.com, rob.herring@...xeda.com, pawel.moll@....com,
	mark.rutland@....com, ian.campbell@...rix.com, rob@...dley.net,
	george.cherian@...com, gregkh@...uxfoundation.org,
	linux-doc@...r.kernel.org, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux@....linux.org.uk, linux-kernel@...r.kernel.org, balbi@...com
Subject: Re: [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

On 08/22/2013 02:31 AM, Kishon Vijay Abraham I wrote:
> The Palmas device contains only a USB VBUS-ID detector, so added a
> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
> types for backward compatibility.

> diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt

>  PALMAS USB COMPARATOR
>  Required Properties:
> - - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
> + - compatible : Should be "ti,palmas-usb-vid". "ti,twl6035-usb" and
> +   "ti,palmas-usb" is deprecated and is kept for backward compatibility.

So this defines one new value and deprecates the two old values.

Why isn't a new "ti,twl6035-usb-vid" entry useful? Don't you still need
SoC-specific compatible values so the driver can enable any SoC-specific
bug-fixes/workarounds later if needed?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/