linux-kernel - Re: [RFC] Get rid of SUBARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1377207175.2737.113@driftwood>
Date:	Thu, 22 Aug 2013 16:32:55 -0500
From:	Rob Landley <rob@...dley.net>
To:	David Daney <ddaney.cavm@...il.com>
Cc:	Richard Weinberger <richard@....at>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Linux-Arch <linux-arch@...r.kernel.org>,
	Michal Marek <mmarek@...e.cz>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	Jeff Dike <jdike@...toit.com>,
	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-m68k <linux-m68k@...ts.linux-m68k.org>,
	Linux MIPS Mailing List <linux-mips@...ux-mips.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	uml-devel <user-mode-linux-devel@...ts.sourceforge.net>
Subject: Re: [RFC] Get rid of SUBARCH

On 08/22/2013 03:55:20 PM, David Daney wrote:
> On 08/22/2013 01:41 PM, Rob Landley wrote:
>> On 08/22/2013 07:58:26 AM, Geert Uytterhoeven wrote:
>>> On Wed, Aug 21, 2013 at 9:51 PM, Sam Ravnborg <sam@...nborg.org>  
>>> wrote:
>>> >> > The series touches also m68k, sh, mips and unicore32.
>>> >> > These architectures magically select a cross compiler if ARCH  
>>> !=
>>> SUBARCH.
>>> >> > Do really need that behavior?
>>> >>
>>> >> This does remove functionality.
>>> >> It allows to build a kernel using e.g. "make ARCH=m68k".
>>> >>
>>> >> Perhaps this can be moved to generic code? Most (not all!)
>>> cross-toolchains
>>> >> are called $ARCH-{unknown-,}linux{,-gnu}.
>>> >> Exceptions are e.g. am33_2.0-linux and bfin-uclinux.
>>> >
>>> > Today you can specify CROSS_COMPILE in Kconfig.
>>> > With this we should be able to remove these hacks.
>>> 
>>> The correct CROSS_COMPILE value depends on the host environment, not
>>> on the target configuration.
>> 
>> Actually it depends on _both_.
>> 
> 
> I think the important issue is not the exact dependencies of the  
> value of CROSS_COMPILE, but rather that it varies enough that  
> automatically choosing a value based on SUBARCH often gives the wrong  
> result.
> 
> Removing SUBARCH and setting CROSS_COMPILE either from the make  
> command line (or environment) or the config file, is a good idea  
> because it simplifies the build system, makes things clearer, and  
> yields more predictable results.
> 
> David Daney

Agreed. Expecting the build to guess the right $CROSS_COMPILE is like  
expecting it to guess the right $PATH. It should be specified, not  
heuristically probed.

Rob--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/