linux-kernel - RE: [RFC PATCH v2 06/11] pstore: Add decompression support to pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A5ED84D3BB3A384992CBB9C77DEDA4D443E8F0B8@USINDEM103.corp.hds.com>
Date:	Thu, 22 Aug 2013 23:04:11 +0000
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com>,
	"linuxppc-dev@...abs.org" <linuxppc-dev@...abs.org>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"keescook@...omium.org" <keescook@...omium.org>
CC:	"jkenisto@...ux.vnet.ibm.com" <jkenisto@...ux.vnet.ibm.com>,
	"ananth@...ibm.com" <ananth@...ibm.com>,
	"benh@...nel.crashing.org" <benh@...nel.crashing.org>,
	"cbouatmailru@...il.com" <cbouatmailru@...il.com>,
	"mahesh@...ux.vnet.ibm.com" <mahesh@...ux.vnet.ibm.com>,
	"ccross@...roid.com" <ccross@...roid.com>
Subject: RE: [RFC PATCH v2 06/11] pstore: Add decompression support to pstore



> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-owner@...r.kernel.org] On Behalf Of Aruna Balakrishnaiah
> Sent: Friday, August 16, 2013 9:18 AM
> To: linuxppc-dev@...abs.org; tony.luck@...el.com; linux-kernel@...r.kernel.org; keescook@...omium.org
> Cc: jkenisto@...ux.vnet.ibm.com; ananth@...ibm.com; benh@...nel.crashing.org; cbouatmailru@...il.com;
> mahesh@...ux.vnet.ibm.com; ccross@...roid.com
> Subject: [RFC PATCH v2 06/11] pstore: Add decompression support to pstore
> 
> Based on the flag 'compressed' set or not, pstore will decompress the
> data returning a plain text file. If decompression fails for a particular
> record it will have the compressed data in the file which can be
> decompressed with 'openssl' command line tool.

If the decompression fails and openssl doesn't work, the worst case is that users can't read the entry.
In that case, pstore is meaningless at all.

Also, for users who want to get a single panic message, a compression is not needed.

So, I think we still have to support non-compression mode.
(IMO, pstore can take kdump as a model. Kdump supports both compression and non-compression mode.)

But, if you think my comment is outside this patchset, it's OK.
We can make it with a separate patch.

Seiji