[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130823080439.GE3535@ulmo>
Date: Fri, 23 Aug 2013 10:04:40 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Tomasz Figa <tomasz.figa@...il.com>
Cc: Xiubo Li-B47053 <B47053@...escale.com>,
Guo Shawn-R65073 <r65073@...escale.com>,
"grant.likely@...aro.org" <grant.likely@...aro.org>,
"linux@....linux.org.uk" <linux@....linux.org.uk>,
"rob@...dley.net" <rob@...dley.net>,
"ian.campbell@...rix.com" <ian.campbell@...rix.com>,
"swarren@...dotorg.org" <swarren@...dotorg.org>,
"mark.rutland@....com" <mark.rutland@....com>,
"pawel.moll@....com" <pawel.moll@....com>,
"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>
Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for
Freescale FTM PWM
On Thu, Aug 22, 2013 at 10:25:30AM +0200, Tomasz Figa wrote:
> On Thursday 22 of August 2013 02:55:42 Xiubo Li-B47053 wrote:
> > Hi Tomasz,
> >
> > Thanks for your comments.
> >
> > > > +- #pwm-cells: Should be 3. Number of cells being used to specify
> > > > PWM
> > > > property.
> > > > + First cell specifies the per-chip channel index of the PWM
> > > > to use, the
> > > > + second cell is the period in nanoseconds and bit 0 in
> > > > the third cell is
> > > > + used to encode the polarity of PWM output. Set bit
> > > > 0 of the third in PWM
> > > > + specifier to 1 for inverse polarity & set to 0
> > > > for normal polarity.
> > >
> > > If the meaning of flags cell is the same as in generic, default PWM
> > > specifier format, then it should be noted here and generic PWM binding
> > > documentation mentioned.
> >
> > OK, How about the following ?
> > - #pwm-cells: Should be 3. See pwm.txt in this directory for a
> > description of the cells format.
>
> I meant just the last cell, which stores flags, but actually this might be
> a good idea, but with slightly extended description. Something among those
> lines:
>
> - #pwm-cells: Should be 3. The default three cell format specified by
> generic PWM bindings are used. Refer to the documentation of generic PWM
> bindings for more information about the meaning of cells.
Actually I prefer the second proposal, that is:
> > - #pwm-cells: Should be 3. See pwm.txt in this directory for a
> > description of the cells format.
We agreed on that wording in another thread and I'd prefer to be
consistent across bindings.
Thierry
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists