linux-kernel - Re: [RFC 17/17] clk: zynq: remove call to of_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4d10bdf-6506-4edc-92cc-2acc67b86602@VA3EHSMHS032.ehs.local>
Date:	Thu, 22 Aug 2013 17:59:36 -0700
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
CC:	Mike Turquette <mturquette@...aro.org>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Michal Simek <michal.simek@...inx.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [RFC 17/17] clk: zynq: remove call to of_clk_init

On Thu, Aug 22, 2013 at 05:26:47PM -0700, Sören Brinkmann wrote:
> Hi Sebastian,
> 
> On Tue, Aug 20, 2013 at 04:04:31AM +0200, Sebastian Hesselbarth wrote:
> > With arch/arm calling of_clk_init(NULL) from time_init(), we can now
> > remove it from corresponding drivers/clk code.
> 
> I think that would break Zynq.
> If I see this correctly you call of_clk_init() from common code,
> _before_ the SOC specific time init function is called.
> The problem is, that we have code setting up a global pointer which is
> required by zynq_clk_setup() which is triggered when of_clk_init() is
> called.
> 
> Let me try to illustrate the current call graph:
> 
> time_init()
> 	zynq_timer_init()		// this machines init_time()
> 		zynq_slcr_init()	// setup System Level Control Registers including a global pointer
> 			zynq_clock_init()
> 				of_clk_init()
> 					zynq_clk_setup()   // requires pointer setup in zynq_slcr_init()
> 					...
> 
> IIUC, your series would change this to:
> time_init()
> 	of_clk_init()
> 		zynq_clk_setup()	// SLCR pointer is not setup/NULL
> 		...
> 	zynq_timer_init()
> 		zynq_slcr_init()	// now the pointer becomes valid

I guess we could move zynq_slcr_init() into init_irq(). I'll give that a
shot tomorrow.

	Sören


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/