linux-kernel - Re: [PATCH] ftrace: add tgid information in task switch event.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Aug 2013 16:33:19 +0800
From:	Jiejing Zhang <jiejzhang@...dia.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Steven Rostedt <rostedt@...dmis.org>,
	Jiejing Zhang <kzjeef@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Eric Miao <emiao@...dia.com>
Subject: Re: [PATCH] ftrace: add tgid information in task switch event.


On 08/21/2013 11:23 PM, Peter Zijlstra wrote:
> On Wed, Aug 21, 2013 at 11:09:44AM -0400, Steven Rostedt wrote:
>>> From: Jiejing Zhang <jiejzhang@...dia.com>
>>>
>>> ftrace only report pid in task switch event, which is
>>> actually thread ID in user space view, the comm of
>>> the thread will be like "Thread-1", "Compiler", etc
>>> in android system, it's useful if we can add tgid
>>> information in ftrace event to find out the process
>>> id, and the process id's comm will help us to figure
>>> out the application, which was useful on data analysis
>>> tools.
> Meh.. are you telling me you really can't do that otherwise?
>
> Adding this information makes the tracepoint slower for everybody else.
> How about you enable trace_sched_process_fork() and track things that
> way?
Thanks for the tip, I have tried fix this by avoid add tgid in ftrace,
actually the relationship between thread and process can be figure by 
analysis these two command's output:
`ps aTH -F` and `ps a -F`

also with fork event, it can totally avoid add such a patch in kernel.

Thanks.
>
> Also, last time I tried to change one of these stupid tracepoints
> userspace broke.. Rostedt says people should be using libtraceevent but
> I'm sceptical.
>
>>> Change-Id: Ia99f58a56d691d770b3beb2f76de0351e6194a4a
> That needs to die.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/