linux-kernel - Re: [PATCH] staging: rtl8187se: Remove pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130823114818.GU22811@mwanda>
Date:	Fri, 23 Aug 2013 14:48:18 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	navin patidar <navinp@...c.in>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	maxtram95@...il.com, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8187se: Remove pt_regs * irq handler
 parameter

On Fri, Aug 23, 2013 at 05:00:06PM +0530, navin patidar wrote:
> struct pt_regs pointer is no longer passed as a irq handler
> argument.
> 

Good eye.

Could you also remove the cast to (void *) so the compiler can catch
this in the future?

-       if (request_irq(dev->irq, (void *)rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {
+       if (request_irq(dev->irq, rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {

regrds,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/