linux-kernel - Re: [PATCH v2 7/7] mm/hwpoison: add '#' to madvise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1377268734-8oq8947y-mutt-n-horiguchi@ah.jp.nec.com>
Date:	Fri, 23 Aug 2013 10:38:54 -0400
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Tony Luck <tony.luck@...el.com>, gong.chen@...ux.intel.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 7/7] mm/hwpoison: add '#' to madvise_hwpoison

On Fri, Aug 23, 2013 at 06:30:41PM +0800, Wanpeng Li wrote:
> Add '#' to madvise_hwpoison.
> 
> Before patch:
> 
> [   95.892866] Injecting memory failure for page 19d0 at b7786000
> [   95.893151] MCE 0x19d0: non LRU page recovery: Ignored
> 
> After patch:
> 
> [   95.892866] Injecting memory failure for page 0x19d0 at 0xb7786000
> [   95.893151] MCE 0x19d0: non LRU page recovery: Ignored
> 
> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

> ---
>  mm/madvise.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/madvise.c b/mm/madvise.c
> index 95795df..588bb19 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -353,14 +353,14 @@ static int madvise_hwpoison(int bhv, unsigned long start, unsigned long end)
>  		if (ret != 1)
>  			return ret;
>  		if (bhv == MADV_SOFT_OFFLINE) {
> -			printk(KERN_INFO "Soft offlining page %lx at %lx\n",
> +			pr_info("Soft offlining page %#lx at %#lx\n",
>  				page_to_pfn(p), start);
>  			ret = soft_offline_page(p, MF_COUNT_INCREASED);
>  			if (ret)
>  				break;
>  			continue;
>  		}
> -		printk(KERN_INFO "Injecting memory failure for page %lx at %lx\n",
> +		pr_info("Injecting memory failure for page %#lx at %#lx\n",
>  		       page_to_pfn(p), start);
>  		/* Ignore return value for now */
>  		memory_failure(page_to_pfn(p), 0, MF_COUNT_INCREASED);
> -- 
> 1.8.1.2
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/