linux-kernel - Re: [PATCH] [BUGFIX] drivers/base: fix show_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130823160802.GA10988@sgi.com>
Date:	Fri, 23 Aug 2013 11:08:02 -0500
From:	Russ Anderson <rja@....com>
To:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH] [BUGFIX] drivers/base: fix show_mem_removable section
	count

On Fri, Aug 23, 2013 at 04:23:10PM +0900, Yasuaki Ishimatsu wrote:
>
> I don't think it works well.
> mem->section_count means how many present section is in the memory_block.
> If 0, 1, 3 and 4 sections are present in the memory_block, mem->section_count
> is 4. In this case, is_mem_sectionremovable is called for section 2. But the
> section is not present. So if the memory_block has hole, same problem will occur.
>
> How about keep sections_per_block loop and add following check:
>
> 		if (!present_section_nr(mem->start_section_nr + i))
> 			continue;

Yes, I will make that change and resubmit the patch.
Thanks.

> Thanks,
> Yasuaki Ishimatsu

-- 
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          rja@....com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/