linux-kernel - Re: [PATCH] mailbox: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Aug 2013 11:37:01 -0500
From:	Suman Anna <s-anna@...com>
To:	Tony Lindgren <tony@...mide.com>
CC:	Jingoo Han <jg1.han@...sung.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>,
	"'Rafael J. Wysocki'" <rafael.j.wysocki@...el.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata()

+ OMAP mailing list

Tony,
Can you pick up this minor cleanup patch?

regards
Suman

On 08/21/2013 09:10 PM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Suman Anna <s-anna@...com>

> ---
>  drivers/mailbox/mailbox-omap2.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mailbox/mailbox-omap2.c b/drivers/mailbox/mailbox-omap2.c
> index eba380d..42d2b89 100644
> --- a/drivers/mailbox/mailbox-omap2.c
> +++ b/drivers/mailbox/mailbox-omap2.c
> @@ -325,7 +325,6 @@ static int omap2_mbox_remove(struct platform_device *pdev)
>  	kfree(privblk);
>  	kfree(mboxblk);
>  	kfree(list);
> -	platform_set_drvdata(pdev, NULL);
>  
>  	return 0;
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/