linux-kernel - Re: [PATCH] dma: ste_dma: Fix warning when CONFIG_ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYT7AMosUKBF5qMQbFBsbh2MoTbrhqR07Y_dPvUSwO7xQ@mail.gmail.com>
Date:	Fri, 23 Aug 2013 20:03:10 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	Kevin Hilman <khilman@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] dma: ste_dma: Fix warning when CONFIG_ARM_LPAE=y

On Thu, Aug 22, 2013 at 2:34 AM, Fabio Estevam <festevam@...il.com> wrote:

> From: Fabio Estevam <fabio.estevam@...escale.com>
>
> When CONFIG_ARM_LPAE=y the following build warning are generated:
>
> drivers/dma/ste_dma40.c:3228:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat]
> drivers/dma/ste_dma40.c:3582:3: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat]
> drivers/dma/ste_dma40.c:3582:3: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t' [-Wformat]
> drivers/dma/ste_dma40.c:3593:5: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t' [-Wformat]
>
> According to Documentation/printk-formats.txt '%pa' can be used to properly
> print 'resource_size_t'.
>
> Also, for printing memory region the '%pr' is more convenient.
>
> Reported-by: Kevin Hilman <khilman@...aro.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Elegant!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Vinod, can you apply this?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/