linux-kernel - Re: [PATCH] usb: acm gadget: Null termintate strings table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130823182121.GA12543@kroah.com>
Date:	Fri, 23 Aug 2013 11:21:21 -0700
From:	Greg KH <greg@...ah.com>
To:	Graham Williams <gwilli@...adcom.com>
Cc:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"balbi@...com" <balbi@...com>
Subject: Re: [PATCH] usb: acm gadget: Null termintate strings table

On Fri, Aug 23, 2013 at 05:51:12PM +0000, Graham Williams wrote:
> 
> The gadget strings table should be null terminated.
> usb_gadget_get_string() loops through the table
> expecting a null at the end of the list.
> 
> Signed-off-by: Graham Williams <gwilli@...adcom.com>

Nice, that works.

> ---
> drivers/usb/gadget/f_acm.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_acm.c
> index 4b7e33e..ab1065a 100644
> --- a/drivers/usb/gadget/f_acm.c
> +++ b/drivers/usb/gadget/f_acm.c
> @@ -285,6 +285,7 @@ static struct usb_string acm_string_defs[] = {
>         [ACM_CTRL_IDX].s = "CDC Abstract Control Model (ACM)",
>         [ACM_DATA_IDX].s = "CDC ACM Data",
>         [ACM_IAD_IDX ].s = "CDC Serial",
> +       {  } /* end of list */

But this doesn't at all :(

Please fix your email client to not convert tabs to spaces.  Email the
patch to yourself and see if you can apply it properly first.  Also, the
kernel file, Documentation/email_clients.txt will help in setting things
up properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/