linux-kernel - Re: [PATCH v3 3/5] clk: Add common __clk_get(), __clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130823231314.GR6617@n2100.arm.linux.org.uk>
Date:	Sat, 24 Aug 2013 00:13:15 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org, mturquette@...aro.org,
	jiada_wang@...tor.com, broonie@...nel.org, vapier@...too.org,
	ralf@...ux-mips.org, kyungmin.park@...sung.com,
	myungjoo.ham@...sung.com, shawn.guo@...aro.org,
	sebastian.hesselbarth@...il.com, LW@...O-electronics.de,
	t.figa@...sung.com, g.liakhovetski@....de,
	laurent.pinchart@...asonboard.com, linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org, linux-mips@...ux-mips.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH v3 3/5] clk: Add common __clk_get(), __clk_put()
	implementations

On Fri, Aug 23, 2013 at 05:03:45PM +0200, Sylwester Nawrocki wrote:
> This patch adds common __clk_get(), __clk_put() clkdev helpers which
> replace their platform specific counterparts when the common clock
> API is enabled.
> 
> The owner module pointer field is added to struct clk so a reference
> to the clock supplier module can be taken by the clock consumers.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>

I'm mostly happy with this now.

> +int __clk_get(struct clk *clk)
> +{
> +	if (clk && !try_module_get(clk->owner))
> +		return 0;
> +
> +	return 1;
> +}
> +EXPORT_SYMBOL(__clk_get);
> +
> +void __clk_put(struct clk *clk)
> +{
> +	if (WARN_ON_ONCE(IS_ERR(clk)))
> +		return;
> +
> +	if (clk)
> +		module_put(clk->owner);
> +}
> +EXPORT_SYMBOL(__clk_put);

Why are these exported?  clkdev can only be built into the kernel, as can
the common clk framework - they can't be modular.  So why would a module
wish to access these directly?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/