linux-kernel - RE: [PATCH -next] block: fix error return code in parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C3050A4DBA34F345975765E43127F10F1C0671B3@szxeml512-mbs.china.huawei.com>
Date:	Fri, 23 Aug 2013 04:58:39 +0000
From:	Caizhiyong <caizhiyong@...wei.com>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	"axboe@...nel.dk" <axboe@...nel.dk>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"kzak@...hat.com" <kzak@...hat.com>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"computersforpeace@...il.com" <computersforpeace@...il.com>,
	"dedekind@...radead.org" <dedekind@...radead.org>
CC:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Wanglin (Albert)" <albert.wanglin@...wei.com>
Subject: RE: [PATCH -next] block: fix error return code in parse_parts()

> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@...il.com]
> Sent: Friday, August 23, 2013 10:48 AM
> To: axboe@...nel.dk; akpm@...ux-foundation.org; Caizhiyong; kzak@...hat.com;
> mag@...go.de; dwmw2@...radead.org; computersforpeace@...il.com;
> dedekind@...radead.org
> Cc: yongjun_wei@...ndmicro.com.cn; linux-kernel@...r.kernel.org
> Subject: [PATCH -next] block: fix error return code in parse_parts()
> 
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fix to return -EINVAL in the parts parse error handling case instead
> of 0(may overwrite to 0 by parse_subpart()), as done elsewhere in this
> function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  block/cmdline-parser.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/cmdline-parser.c b/block/cmdline-parser.c
> index 18fb435..cc2637f 100644
> --- a/block/cmdline-parser.c
> +++ b/block/cmdline-parser.c
> @@ -135,6 +135,7 @@ static int parse_parts(struct cmdline_parts **parts, const char
> *bdevdef)
> 
>  	if (!newparts->subpart) {
>  		pr_warn("cmdline partition has no valid partition.");
> +		ret = -EINVAL;


Seems OK to me.

>  		goto fail;
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/