lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 24 Aug 2013 16:44:05 -0700
From:	"Nicholas A. Bellinger" <>
To:	Christoph Hellwig <>
Cc:	"Nicholas A. Bellinger" <>,
	target-devel <>,
	lkml <>,
	linux-scsi <>,
	Christoph Hellwig <>, Hannes Reinecke <>,
	Martin Petersen <>,
	Chris Mason <>,
	Roland Dreier <>,
	James Bottomley <>
Subject: Re: [PATCH-v2 06/12] target: Add memory allocation for
 bidirectional commands

On Sat, 2013-08-24 at 08:18 -0700, Christoph Hellwig wrote:
> >  static int
> > +transport_generic_get_mem_bidi(struct se_cmd *cmd)
> Except for the fields touched in struct se_cmd this is a duplication
> of transport_generic_get_mem.  I'd suggest to factor that one into
> a new helper:
> static int
> target_alloc_sgl(struct scatterlist **sgl, unsigned int **nents,
> 		u32 length, gfp_t gfp_mask)
> {
> 	..
> }
> and then call that one from transport_generic_new_cmd directly,

Sounds reasonable enough, doing that bit of refactoring now..

> including opencoding the actual BIDI case there as a first step.

Not sure why this needs to be opencoded for BIDI, instead of just doing
target_alloc_sgl(&cmd->t_bidi_data_sg, ...) for the two SCF_BIDI ||
SCF_COMPARE_AND_WRITE cases in transport_generic_new_cmd()..?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists