linux-kernel - Re: [PATCH] MAX7301 GPIO: Reverting "Do not force SPI speed when using OF Platform"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 24 Aug 2013 18:55:09 +0200
From:	christophe leroy <christophe.leroy@....fr>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Roland Stigge <stigge@...com.de>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] MAX7301 GPIO: Reverting "Do not force SPI speed when
 using OF Platform"

Le 23/08/2013 19:47, Linus Walleij a écrit :
> On Tue, Aug 20, 2013 at 8:29 AM, Christophe Leroy
> <christophe.leroy@....fr> wrote:
>
>> This patch reverts commit 047b93a35961f7a6561e6f5dcb040738f822b892 which breaks
>> MAX7301 GPIO driver because that commit was dependant on a rejected patch that
>> was implementing selection of SPI speed from the Device Tree.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
> Patch applied with Roland's ACK.
>
> But seriously, this is the kind of stuff that scares me a lot,
> when developers merge dependent patches into two different
> trees, that is just a recipe for chaos and me getting flamed
> by other kernel maintainers.
>
> There is *no* mention of this dependency in the other
> commit.

I'm very sorry for this mishap. If I didn't mention it in the commit, 
this is because when I developped the change I submitted you a few 
months back, I was not aware of that other patch. It looks like it has 
been in my company's kernel tree for years, therefore in my mind it was 
a standard feature of the kernel. It looks like nobody had tried and 
submitted it for inclusion previously.
That's thanks to Roland that I discovered it was indeed not a standard 
feature, then I tried to submit that patch a week ago and it was 
rejected by Stephen Warren for good reason.
For me it is a lesson learnt, and I'll make sure it doesn't happen again.

Regards
Christophe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/