linux-kernel - Re: [PATCH] mmc: omap_hsmmc: clear status flags before starting a new command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <521A5D7C.4050208@ti.com>
Date:	Mon, 26 Aug 2013 01:09:40 +0530
From:	Balaji T K <balajitk@...com>
To:	Francesco Lavra <francescolavra.fl@...il.com>
CC:	Chris Ball <cjb@...top.org>, <linux-mmc@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: omap_hsmmc: clear status flags before starting a
 new command

On Saturday 29 June 2013 11:55 AM, Francesco Lavra wrote:
> Commit 1f6b9fa40e76fffaaa0b3bd6a0bfdcf1cdc06efa consolidated writes to
> the STAT register in one location, moving them from omap_hsmmc_do_irq()
> to omap_hsmmc_irq(). This move has the unwanted side effect that the
> controller status flags are potentially cleared after a new command has
> been started as a consequence of reading the previous status flags.
> This means that if the new command changes the status flags before the
> IRQ routine returns, those flags may be cleared without handling the
> event which asserted them, and thus missing the event.
> Move the writing of the STAT register back in omap_hsmmc_do_irq(),
> before handling the status flags which generated the interrupt.
>
> Signed-off-by: Francesco Lavra <francescolavra.fl@...il.com>

Reviewed and Tested-by: Balaji T K <balajitk@...com>

> ---
>   drivers/mmc/host/omap_hsmmc.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index eccedc7..301cb7e 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1041,6 +1041,7 @@ static void omap_hsmmc_do_irq(struct omap_hsmmc_host *host, int status)
>   		}
>   	}
>
> +	OMAP_HSMMC_WRITE(host->base, STAT, status);
>   	if (end_cmd || ((status & CC_EN) && host->cmd))
>   		omap_hsmmc_cmd_done(host, host->cmd);
>   	if ((end_trans || (status & TC_EN)) && host->mrq)
> @@ -1060,7 +1061,6 @@ static irqreturn_t omap_hsmmc_irq(int irq, void *dev_id)
>   		omap_hsmmc_do_irq(host, status);
>
>   		/* Flush posted write */
> -		OMAP_HSMMC_WRITE(host->base, STAT, status);
>   		status = OMAP_HSMMC_READ(host->base, STAT);
>   	}
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/