linux-kernel - Re: [PATCH v2 4/4] pinctrl: mvebu: Convert to use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130826175925.5774a277@xhacker>
Date:	Mon, 26 Aug 2013 17:59:25 +0800
From:	Jisheng Zhang <jszhang@...vell.com>
To:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
CC:	"jason@...edaemon.net" <jason@...edaemon.net>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"gregory.clement@...e-electrons.com" 
	<gregory.clement@...e-electrons.com>,
	"thomas.petazzoni@...e-electrons.com" 
	<thomas.petazzoni@...e-electrons.com>,
	"mturquette@...aro.org" <mturquette@...aro.org>,
	"sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] pinctrl: mvebu: Convert to use
 devm_ioremap_resource

Hi Ezequiel,

On Sat, 24 Aug 2013 08:06:25 -0700
Ezequiel Garcia <ezequiel.garcia@...e-electrons.com> wrote:

> Hi Jisheng,
> 
> On Fri, Aug 23, 2013 at 10:34:02AM +0800, Jisheng Zhang wrote:
> > Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> > ---
> >  drivers/pinctrl/mvebu/pinctrl-mvebu.c | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> > 
> 
> Mmm.. I would prefer to see a better commit log for this patch.
> In particular, the current code is buggy (for there's a leak) and
> this patch fixes it.
> Care to write something meaningful and re-send? (except the patch

Done. Could you please review again?

> Mike already took, I guess).
> 
> With that changes you can add:
> 
> Reviewed-by: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>T
Thank you for your help
> 
> for the whole series.

Best Regards,
Jisheng


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/