linux-kernel - Re: [PATCH v3 1/3] arm: mvebu: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130826180636.3e2bdb20@xhacker>
Date:	Mon, 26 Aug 2013 18:06:36 +0800
From:	Jisheng Zhang <jszhang@...vell.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
CC:	"jason@...edaemon.net" <jason@...edaemon.net>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"gregory.clement@...e-electrons.com" 
	<gregory.clement@...e-electrons.com>,
	"ezequiel.garcia@...e-electrons.com" 
	<ezequiel.garcia@...e-electrons.com>,
	"mturquette@...aro.org" <mturquette@...aro.org>,
	"sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] arm: mvebu: add missing of_node_put() to fix
 reference leak

Dear Thomas,

On Mon, 26 Aug 2013 03:02:00 -0700
Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> wrote:

> Dear Jisheng Zhang,
> 
> On Mon, 26 Aug 2013 17:56:19 +0800, Jisheng Zhang wrote:
> 
> > diff --git a/arch/arm/mach-mvebu/armada-370-xp.c
> > b/arch/arm/mach-mvebu/armada-370-xp.c index 97cbb80..8a1ae83 100644
> > --- a/arch/arm/mach-mvebu/armada-370-xp.c
> > +++ b/arch/arm/mach-mvebu/armada-370-xp.c
> > @@ -64,6 +64,7 @@ static void __init armada_370_xp_mbus_init(void)
> >  			ARMADA_370_XP_MBUS_WINS_SIZE,
> >  			of_translate_address(dn, &sdram_wins_offs),
> >  			ARMADA_370_XP_SDRAM_WINS_SIZE);
> > +	of_node_put(dn);
> >  }
> 
> With the integration of Ezequiel patches that add DT support to the
> mvebu-mbus driver, this chunk of the code is no longer needed, as of
> linux-next.
> 
Got it. Thanks for the information. Will send v4 latter

Thanks,
Jisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/