lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 26 Aug 2013 14:18:38 +0400
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	黃清隆 <ching2048@...ca.com.tw>
Cc:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, billion@...ca.com.tw
Subject: Re: [PATCH 1/3] arcmsr: Support Areca new SATA Raid Adapter
 ARC1214/1224/1264/1284

On Mon, 2013-08-26 at 12:14 +0800, 黃清隆 wrote:
>  From: Ching <ching2048@...ca.com.tw>
> 
> Support Areca new SATA Raid adapter ARC1214/1224/1264/1284.
> Modify maximum outstanding command number, notify command complete with auto
> request sense
> Signed-off-by: Ching  <ching2048@...ca.com.tw>

Checkpatch really doesn't like this:

total: 1 errors, 173 warnings, 7131 lines checked

I fixed up the error and the few relevant warnings.  I don't really care
about the lines over 80 characters.  However, if you're going to have
long lines, don't split strings (another checkpatch complaint).  I'd
also like to see the spurious braces removed in a later patch, please.
The prinks without a KERN_ also need fixing.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ