[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-id: <001e01cea1f3$b0d5a780$1280f680$%han@samsung.com>
Date: Mon, 26 Aug 2013 09:32:05 +0900
From: Jingoo Han <jg1.han@...sung.com>
To: 'Vinod Koul' <vinod.koul@...el.com>
Cc: 'Dan Williams' <djbw@...com>, linux-kernel@...r.kernel.org,
'Simon Horman' <horms@...ge.net.au>,
'Andy Shevchenko' <andriy.shevchenko@...ux.jf.intel.com>,
'Fabio Estevam' <fabio.estevam@...escale.com>,
'Shawn Guo' <shawn.guo@...aro.org>,
'Jingoo Han' <jg1.han@...sung.com>
Subject: [PATCH RESEND] dma: sh: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@...sung.com>
Acked-by: Simon Horman <horms+renesas@...ge.net.au>
---
drivers/dma/sh/shdmac.c | 3 ---
drivers/dma/sh/sudmac.c | 2 --
2 files changed, 5 deletions(-)
diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
index c7faded..282e93f 100755
--- a/drivers/dma/sh/shdmac.c
+++ b/drivers/dma/sh/shdmac.c
@@ -882,7 +882,6 @@ rst_err:
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- platform_set_drvdata(pdev, NULL);
shdma_cleanup(&shdev->shdma_dev);
eshdma:
synchronize_rcu();
@@ -911,8 +910,6 @@ static int sh_dmae_remove(struct platform_device *pdev)
sh_dmae_chan_remove(shdev);
shdma_cleanup(&shdev->shdma_dev);
- platform_set_drvdata(pdev, NULL);
-
synchronize_rcu();
return 0;
diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c
index 3c7d2b8..bf85b8e 100755
--- a/drivers/dma/sh/sudmac.c
+++ b/drivers/dma/sh/sudmac.c
@@ -391,7 +391,6 @@ static int sudmac_probe(struct platform_device *pdev)
chan_probe_err:
sudmac_chan_remove(su_dev);
- platform_set_drvdata(pdev, NULL);
shdma_cleanup(&su_dev->shdma_dev);
return err;
@@ -405,7 +404,6 @@ static int sudmac_remove(struct platform_device *pdev)
dma_async_device_unregister(dma_dev);
sudmac_chan_remove(su_dev);
shdma_cleanup(&su_dev->shdma_dev);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists