linux-kernel - Re: [PATCH] dma: sh: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1308261134240.1767@axis700.grange>
Date:	Mon, 26 Aug 2013 14:38:17 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Jingoo Han <jg1.han@...sung.com>
cc:	'Vinod Koul' <vinod.koul@...el.com>, 'Dan Williams' <djbw@...com>,
	linux-kernel@...r.kernel.org,
	'Simon Horman' <horms+renesas@...ge.net.au>
Subject: Re: [PATCH] dma: sh: remove unnecessary platform_set_drvdata()

On Wed, 21 Aug 2013, Jingoo Han wrote:

> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

This has to be updated on top of current 
http://git.infradead.org/users/vkoul/slave-dma.git next branch, there it 
will patch the drivers/dma/sh/shdmac.c file, not drivers/dma/sh/shdma.c. 
After that feel free to add my

Acked-by: Guennadi Liakhovetski <g.liakhovetski+renesas@...il.com>

Thanks
Guennadi

> ---
>  drivers/dma/sh/shdma.c  |    3 ---
>  drivers/dma/sh/sudmac.c |    2 --
>  2 files changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/sh/shdma.c b/drivers/dma/sh/shdma.c
> index 211e2f1..208de0f 100644
> --- a/drivers/dma/sh/shdma.c
> +++ b/drivers/dma/sh/shdma.c
> @@ -873,7 +873,6 @@ rst_err:
>  	pm_runtime_put(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  
> -	platform_set_drvdata(pdev, NULL);
>  	shdma_cleanup(&shdev->shdma_dev);
>  eshdma:
>  	if (dmars)
> @@ -917,8 +916,6 @@ static int sh_dmae_remove(struct platform_device *pdev)
>  		iounmap(shdev->dmars);
>  	iounmap(shdev->chan_reg);
>  
> -	platform_set_drvdata(pdev, NULL);
> -
>  	synchronize_rcu();
>  	kfree(shdev);
>  
> diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c
> index c494417..23fffc8 100644
> --- a/drivers/dma/sh/sudmac.c
> +++ b/drivers/dma/sh/sudmac.c
> @@ -393,7 +393,6 @@ static int sudmac_probe(struct platform_device *pdev)
>  chan_probe_err:
>  	sudmac_chan_remove(su_dev);
>  
> -	platform_set_drvdata(pdev, NULL);
>  	shdma_cleanup(&su_dev->shdma_dev);
>  
>  	return err;
> @@ -407,7 +406,6 @@ static int sudmac_remove(struct platform_device *pdev)
>  	dma_async_device_unregister(dma_dev);
>  	sudmac_chan_remove(su_dev);
>  	shdma_cleanup(&su_dev->shdma_dev);
> -	platform_set_drvdata(pdev, NULL);
>  
>  	return 0;
>  }
> -- 
> 1.7.10.4
> 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/