linux-kernel - Re: [PATCH] nbd: correct disconnect behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130826125459.GB20329@amd.pavel.ucw.cz>
Date:	Mon, 26 Aug 2013 14:54:59 +0200
From:	Pavel Machek <pavel@....cz>
To:	Rob Landley <rob@...dley.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Clements <paul.clements@...eleye.com>,
	linux-kernel@...r.kernel.org, nbd-general@...ts.sourceforge.net
Subject: Re: [PATCH] nbd: correct disconnect behavior

Hi!

> >> --- a/include/linux/nbd.h
> >> +++ b/include/linux/nbd.h
> >> @@ -41,6 +41,7 @@ struct nbd_device {
> >>  	u64 bytesize;
> >>  	pid_t pid; /* pid of nbd-client, if attached */
> >>  	int xmit_timeout;
> >> +	int disconnect; /* a disconnect has been requested by user */
> >>  };
> >
> >The cool kids are using bool lately ;)
> 
> No, they're not. The C++ guys and stuffy old ex-cobol types are, and
> think it helps. (Does any architecture anywhere _not_ use int for
> bool?)

Its useful as documentation, and while it is probably int,
faster/smaller code can probably generated in some cases.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/