linux-kernel - Re: [PATCH v4 9/10] mm/hwpoison: change permission of corrupt-pfn/unpoison-pfn to 0400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 26 Aug 2013 11:47:35 -0400
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Tony Luck <tony.luck@...el.com>, gong.chen@...ux.intel.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 9/10] mm/hwpoison: change permission of
 corrupt-pfn/unpoison-pfn to 0400

On Mon, Aug 26, 2013 at 05:08:38PM +0800, Wanpeng Li wrote:
> On Mon, Aug 26, 2013 at 04:46:13PM +0800, Wanpeng Li wrote:
> >Hwpoison inject doesn't implement read method for corrupt-pfn/unpoison-pfn
> >attributes:
> >
> ># cat /sys/kernel/debug/hwpoison/corrupt-pfn 
> >cat: /sys/kernel/debug/hwpoison/corrupt-pfn: Permission denied
> ># cat /sys/kernel/debug/hwpoison/unpoison-pfn 
> >cat: /sys/kernel/debug/hwpoison/unpoison-pfn: Permission denied
> >
> >This patch change the permission of corrupt-pfn/unpoison-pfn to 0400.
> >
> >Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> >---
> > mm/hwpoison-inject.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> >index 3a61efc..8b77bfd 100644
> >--- a/mm/hwpoison-inject.c
> >+++ b/mm/hwpoison-inject.c
> >@@ -88,12 +88,12 @@ static int pfn_inject_init(void)
> > 	 * hardware status change, hence do not require hardware support.
> > 	 * They are mainly for testing hwpoison in software level.
> > 	 */
> >-	dentry = debugfs_create_file("corrupt-pfn", 0600, hwpoison_dir,
> >+	dentry = debugfs_create_file("corrupt-pfn", 0400, hwpoison_dir,
> > 					  NULL, &hwpoison_fops);
> > 	if (!dentry)
> > 		goto fail;
> >
> >-	dentry = debugfs_create_file("unpoison-pfn", 0600, hwpoison_dir,
> >+	dentry = debugfs_create_file("unpoison-pfn", 0400, hwpoison_dir,
> > 				     NULL, &unpoison_fops);
> > 	if (!dentry)
> > 		goto fail;
> >-- 
> >1.8.1.2
> 
> Fix this patch: 

Reviewed-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/