lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130826162020.GE6329@mwanda>
Date:	Mon, 26 Aug 2013 19:20:20 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Iker Pedrosa <ikerpedrosam@...il.com>
Cc:	pavel@....cz, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, harsh1kumar@...il.com,
	linux-kernel@...r.kernel.org, mujeeb.adil@...il.com,
	justinmattock@...il.com
Subject: Re: [PATCH 09/24] Staging: winbond: reg: fixed some lines over 80
 characters

On Mon, Aug 26, 2013 at 05:10:08PM +0200, Iker Pedrosa wrote:
> @@ -926,7 +928,8 @@ static void Set_ChanIndep_RfData_al7230_24(struct hw_data *pHwData, u32 *pltmp,
>  	u8	i;
>  	for (i = 0; i < number; i++) {
>  		pHwData->phy_para[i] = al7230_rf_data_24[i];
> -		pltmp[i] = (1 << 31) | (0 << 30) | (24 << 24) | (al7230_rf_data_24[i] & 0xffffff);
> +		pltmp[i] = (1 << 31) | (0 << 30) | (24 << 24)
> +				   | (al7230_rf_data_24[i] & 0xffffff);

It's always a bit hard for me to know how picky to be.  Normally the '|'
would be on the first line here.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ