linux-kernel - Re: [PATCH 05/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1377535823.1782.46.camel@joe-AO722>
Date:	Mon, 26 Aug 2013 09:50:23 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Iker Pedrosa <ikerpedrosam@...il.com>, pavel@....cz,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	harsh1kumar@...il.com, linux-kernel@...r.kernel.org,
	mujeeb.adil@...il.com, justinmattock@...il.com
Subject: Re: [PATCH 05/24] Staging: winbond: phy_calibration: fixed some
 lines over 80 characters

On Mon, 2013-08-26 at 19:02 +0300, Dan Carpenter wrote:
> On Mon, Aug 26, 2013 at 05:10:04PM +0200, Iker Pedrosa wrote:
[]
> > diff --git a/drivers/staging/winbond/phy_calibration.c b/drivers/staging/winbond/phy_calibration.c
[]
> > @@ -1233,8 +1233,10 @@ u8 _rx_iq_calibration_loop_winbond(struct hw_data *phw_data, u16 factor, u32 fre
> >  		b_2 = (rot_image_q_b * 32768) / rot_tone_i_b -
> >  			phw_data->iq_rsdl_phase_tx_d2;
> >  
> > -		PHY_DEBUG(("[CAL]    ** iq_rsdl_gain_tx_d2 = %d\n", phw_data->iq_rsdl_gain_tx_d2));
> > -		PHY_DEBUG(("[CAL]    ** iq_rsdl_phase_tx_d2= %d\n", phw_data->iq_rsdl_phase_tx_d2));
> > +		PHY_DEBUG(("[CAL]    ** iq_rsdl_gain_tx_d2 = %d\n",
> > +				   phw_data->iq_rsdl_gain_tx_d2));
> 
> Don't redo this, but really these should be aligned like this:
> 
> 		PHY_DEBUG(("[CAL]    ** iq_rsdl_gain_tx_d2 = %d\n",
> 			   phw_data->iq_rsdl_gain_tx_d2));
> 
> In the end, we're going to remove all these debugging prints so it's
> not worth redoing in a later patch.  What you have is fine.  The
> message itself is sort of nonsense.

Especially true because the only #define for PHY_DEBUG is:

#define PHY_DEBUG(msg, args...)

None of this does anything anyway.

It'd be better to send a removal of the whole lot.

Does anyone still use this driver?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/