| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20130826.170922.2228024390320689580.davem@davemloft.net> Date: Mon, 26 Aug 2013 17:09:22 -0400 (EDT) From: David Miller <davem@...emloft.net> To: joe@...ches.com Cc: mrkiko.rs@...il.com, gregkh@...uxfoundation.org, oliver@...kum.org, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver From: Joe Perches <joe@...ches.com> Date: Mon, 26 Aug 2013 14:05:55 -0700 > On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote: >> From: Joe Perches <joe@...ches.com> >> Date: Mon, 26 Aug 2013 13:45:13 -0700 >> >> > I think the premise of local variable >> > declaration by line length is flawed. >> >> I disagree. >> >> > It can't work when local variables are >> > dependent on initialization order as >> > above. >> >> Move the initialization below the declarations. > > So all initializations should be on separate > lines from declarations? No, you can often make it work out when the initialization occurs on the same time. Like everything else in life, you evaluate it on a case by case basis. Don't try to over-simplify things and act as if they are black and white when they aren't. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists