linux-kernel - Re: [PATCH 3/3] raid6/test: replace echo -e with printf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Aug 2013 14:15:45 +1000
From:	NeilBrown <neilb@...e.de>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Max Filippov <jcmvbkbc@...il.com>, linux-kernel@...r.kernel.org,
	Sam Ravnborg <sam@...nborg.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Jim Kukunas <james.t.kukunas@...ux.intel.com>,
	Yuanhan Liu <yuanhan.liu@...ux.intel.com>
Subject: Re: [PATCH 3/3] raid6/test: replace echo -e with printf

On Thu, 22 Aug 2013 17:09:11 +0200 "H. Peter Anvin" <hpa@...or.com> wrote:

> Acked-by: H. Peter Anvin <hpa@...or.com>

Applied with the Ack - thanks.

NeilBrown

> 
> Max Filippov <jcmvbkbc@...il.com> wrote:
> >-e is a non-standard echo option, echo output is
> >implementation-dependent when it is used. Replace echo -e with printf
> >as
> >suggested by POSIX echo manual.
> >
> >Cc: NeilBrown <neilb@...e.de>
> >Cc: Jim Kukunas <james.t.kukunas@...ux.intel.com>
> >Cc: "H. Peter Anvin" <hpa@...or.com>
> >Cc: Yuanhan Liu <yuanhan.liu@...ux.intel.com>
> >Signed-off-by: Max Filippov <jcmvbkbc@...il.com>
> >---
> > lib/raid6/test/Makefile |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
> >index 087332d..73b0151 100644
> >--- a/lib/raid6/test/Makefile
> >+++ b/lib/raid6/test/Makefile
> >@@ -28,7 +28,7 @@ ifeq ($(IS_X86),yes)
> >                     gcc -c -x assembler - >&/dev/null &&	\
> >                     rm ./-.o && echo -DCONFIG_AS_AVX2=1)
> > else
> >-        HAS_ALTIVEC := $(shell echo -e '\#include <altivec.h>\nvector
> >int a;' |\
> >+        HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector
> >int a;\n' |\
> >                          gcc -c -x c - >&/dev/null && \
> >                          rm ./-.o && echo yes)
> >         ifeq ($(HAS_ALTIVEC),yes)
> 


Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)