linux-kernel - Re: [BUG] 3.7-rc regression bisected: s2disk fails to resume image: Processes could not be frozen, cannot continue resuming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130827074843.ba1b6f62cc0a6dca8e47c06c@gmail.com>
Date:	Tue, 27 Aug 2013 07:48:43 +0400
From:	Andrew Savchenko <bircoph@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	linux-pm@...r.kernel.org, viro@...iv.linux.org.uk,
	suspend-devel@...ts.sourceforge.net
Subject: Re: [BUG] 3.7-rc regression bisected: s2disk fails to resume image:
 Processes could not be frozen, cannot continue resuming

Hello,

On Mon, 12 Aug 2013 23:44:15 +0400 Andrew Savchenko wrote:
> after a kernel update from 3.5.7 to the latest stable I found that
> user-space resume (from suspend-1.0 aka uswsusp) no longer works.
> Kernel-space suspend and resume work fine (e.g. echo disk
> > /sys/power/state), problem is with user-space support. (I need
> user-space version because it supports image encryption.)
> 
> After resume (essentially linuxrc) application loads image it fails
> to apply it:
> 
> ========================================================
> Processes could not be frozen, cannot continue resuming.
> Error 11: Resource temporarily unavailable
> 
> You can now boot the system and lose the saved state
> or reboot and try again.
> 
> [Notice that if you decide to reboot, you MUST NOT mount
> any filesystems before a successful resume.
> Resuming after some filesystems have been mounted
> will badly damage these filesystems.]
> 
> Do you want to continue booting (Y/n)?
> ========================================================
> 
> Error code wasn't originally showed, I added it to suspend tool to
> aid debugging. Essentially freeze ioctl on /dev/snapshot fails with
> this error.
> 
> I bisected a commit which introduces this bug:
> 
> ========================================================
> commit ba4df2808a86f8b103c4db0b8807649383e9bd13 
> Author: Al Viro <viro@...iv.linux.org.uk> 
> Date:   Tue Oct 2 15:29:10 2012 -0400 
> 
>     don't bother with kernel_thread/kernel_execve for launching
> linuxrc 
>     exec_usermodehelper_fns() will do just fine... 
>     
>     Signed-off-by: Al Viro <viro@...iv.linux.org.uk> 
> ========================================================
> 
> In fact this commit induced/triggered at least two bugs: the first one
> I'm facing now and the second one was fixed in commit
> f0de17c0babe7f29381892def6b37e9181a53410:
> make sure that /linuxrc has std{in,out,err}.
> 
> As a temporarily workaround for this issue I reverted all changes for
> init/do_mounts_initrd.c up to the latest working commit
> cb450766bcafc7bd7d40e9a5a0050745e8c68b3e considering the kernel API
> changes (kernel_execve -> sys_execve). See linuxrc-workaround.patch.
> I understand this isn't a proper solution, I just want to show what
> code works for me.
> 
> I also found an interesting LKML discussion about s2disk and freezer
> issue: http://www.spinics.net/lists/linux-nfs/msg38160.html
> Maybe it is related to this bug, but patch proposed there doesn't in
> my case.
> 
> Kernel config which fails with
> ba4df2808a86f8b103c4db0b8807649383e9bd13 and works with
> f0de17c0babe7f29381892def6b37e9181a53410 is also attached.
> 
> As this issue maybe hardware related, the system is 32-bit EEE PC
> 1000H with Atom N270, 2GB RAM, 750 GB SATA drive.
> 
> Additional (but probably useless) information on this bug may be found
> here: https://forums.gentoo.org/viewtopic-p-7371120.html

This bug is still here with 3.11-rc7 and 3.10.9.
I opened a kernel bug 60802 for this issue:
https://bugzilla.kernel.org/show_bug.cgi?id=60802

Any ideas?

Best regards,
Andrew Savchenko

Content of type "application/pgp-signature" skipped