linux-kernel - Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADApbehFDH2-vJMHuVPq8i+zR0fm4ii36JNB_CEKaYEx0r23zw@mail.gmail.com>
Date:	Tue, 27 Aug 2013 14:11:58 +0800
From:	Chao Xie <xiechao.mail@...il.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Chao Xie <chao.xie@...vell.com>, Lee Jones <lee.jones@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL

On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz <sameo@...ux.intel.com> wrote:
> Hi Xie,
>
> On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote:
>> User pass platform data to device, and platform data may be
>> NULL.
> In which case do you get that ? With DT ?
> Should rtc_init fail when pdata is NULL ?
>
> You need to explain that, be it only for us to know if it's a critical
> fix or not.
>
Sorry for late response.
If pdata is NULL, the driver will fail. So the error check should be done at
the beginning of probe.
If (!pdata)
   return -EINVAL;

Is that OK?

> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/