linux-kernel - Re: [PATCH] pinctrl: pinctrl-single: Convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <521CA2A9.5060200@ti.com>
Date:	Tue, 27 Aug 2013 18:29:21 +0530
From:	ManishBadarkhe <manishv.b@...com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	<davinci-linux-open-source@...ux.davincidsp.com>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<tony@...mide.com>, <linus.walleij@...aro.org>
Subject: Re: [PATCH] pinctrl: pinctrl-single: Convert to devm_ioremap_resource()

Hi

On Tuesday 27 August 2013 05:49 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 27-08-2013 11:05, Vishwanathrao Badarkhe, Manish wrote:
>
>> From: "Vishwanathrao Badarkhe, Manish" <manishv.b@...com>
>
>> Convert devm_request_mem_region() and devm_ioremap() to
>> devm_ioremap_resource() which provides more consistent
>> error handling to manage resource.
>
>> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@...com>
>> ---
>> :100644 100644 7323cca... b0fef18... M drivers/pinctrl/pinctrl-single.c
>>   drivers/pinctrl/pinctrl-single.c |   21 +++------------------
>>   1 file changed, 3 insertions(+), 18 deletions(-)
>
>> diff --git a/drivers/pinctrl/pinctrl-single.c 
>> b/drivers/pinctrl/pinctrl-single.c
>> index 7323cca..b0fef18 100644
>> --- a/drivers/pinctrl/pinctrl-single.c
>> +++ b/drivers/pinctrl/pinctrl-single.c
>> @@ -1556,24 +1556,9 @@ static int pcs_probe(struct platform_device 
>> *pdev)
>>                             "pinctrl-single,bit-per-mux");
>>
>>       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -    if (!res) {
>> -        dev_err(pcs->dev, "could not get resource\n");
>> -        return -ENODEV;
>> -    }
>> -
>> -    pcs->res = devm_request_mem_region(pcs->dev, res->start,
>> -            resource_size(res), DRIVER_NAME);
>> -    if (!pcs->res) {
>
>    Is pcs->res used anywhere else?

My bad, I have not seen this variable is used in another functions too.
>
>> -        dev_err(pcs->dev, "could not get mem_region\n");
>> -        return -EBUSY;
>> -    }
>> -
>> -    pcs->size = resource_size(pcs->res);
>
>    Is pcs->size used anywhere else?
My bad, I have not seen this variable is used in another functions too.
>
>> -    pcs->base = devm_ioremap(pcs->dev, pcs->res->start, pcs->size);
>> -    if (!pcs->base) {
>> -        dev_err(pcs->dev, "could not ioremap\n");
>> -        return -ENODEV;
>> -    }
>> +    pcs->base = devm_ioremap_resource(pcs->dev, res);
>> +    if (IS_ERR(pcs->base))
>> +        return PTR_ERR(pcs->base);
>
I will go through code again and update it accordingly.
>
Regards
Manish Badarkhe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/