linux-kernel - Re: [PATCH 3/4] asm-generic: Add missing include guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <521CA4DC.6010506@imgtec.com>
Date:	Tue, 27 Aug 2013 14:08:44 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
CC:	Arnd Bergmann <arnd@...db.de>, Roland McGrath <roland@...hat.com>,
	"Oleg Nesterov" <oleg@...hat.com>, <linux-arch@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] asm-generic: Add missing include guards

On 08/08/13 22:07, Rasmus Villemoes wrote:
> Add include guards to include/asm-generic/{ide_iops,unistd,xor}.h.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  include/asm-generic/ide_iops.h |    4 ++++
>  include/asm-generic/unistd.h   |    5 +++++
>  include/asm-generic/xor.h      |    4 ++++
>  3 files changed, 13 insertions(+)
> 
> diff --git a/include/asm-generic/unistd.h b/include/asm-generic/unistd.h
> index cccc86e..0cff2e9 100644
> --- a/include/asm-generic/unistd.h
> +++ b/include/asm-generic/unistd.h
> @@ -1,3 +1,6 @@
> +#ifndef _ASM_GENERIC_UNISTD_H
> +#define _ASM_GENERIC_UNISTD_H
> +
>  #include <uapi/asm-generic/unistd.h>
>  #include <linux/export.h>
>  
> @@ -10,3 +13,5 @@
>  #define __ARCH_WANT_STAT64
>  #define __ARCH_WANT_SYS_LLSEEK
>  #endif
> +
> +#endif /* _ASM_GENERIC_UNISTD_H */

I think the lack of include guards in unistd.h is intentional. See for
example the very end of arch/metag/kernel/sys_metag.c.

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/