linux-kernel - Re: [PATCH 4/4] staging: ozwpan: Return error, if PD is not connected.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <521CE19D.2000805@cogentembedded.com>
Date:	Tue, 27 Aug 2013 21:27:57 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Rupesh Gujare <rupesh.gujare@...el.com>
CC:	devel@...uxdriverproject.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH 4/4] staging: ozwpan: Return error, if PD is not connected.

Hello.

On 08/27/2013 07:53 PM, Rupesh Gujare wrote:

> Return error if we receive write(), while PD is not connected.

> Signed-off-by: Rupesh Gujare <rupesh.gujare@...el.com>
> ---
>   drivers/staging/ozwpan/ozcdev.c |    2 ++
>   1 file changed, 2 insertions(+)

> diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
> index 03b41ee..22cb2ae 100644
> --- a/drivers/staging/ozwpan/ozcdev.c
> +++ b/drivers/staging/ozwpan/ozcdev.c
> @@ -162,6 +162,8 @@ static ssize_t oz_cdev_write(struct file *filp, const char __user *buf,
>   	spin_unlock_bh(&g_cdev.lock);
>   	if (pd == NULL)
>   		return -1;

    Note that returning -EPERM here is hardly correct.

> +	if (!(pd->state & OZ_PD_S_CONNECTED))
> +		return -ENXIO;

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/