linux-kernel - Re: [PATCH] serial: omap: Fix IRQ handling return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130827173819.GD21564@kroah.com>
Date:	Tue, 27 Aug 2013 10:38:19 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Kevin Hilman <khilman@...aro.org>
Cc:	Alexander Savchenko <oleksandr.savchenko@...com>, jslaby@...e.cz,
	linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	balbi@...com, linux-omap <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] serial: omap: Fix IRQ handling return value

On Tue, Aug 27, 2013 at 07:30:19AM -0700, Kevin Hilman wrote:
> Greg,
> 
> 
> On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman <khilman@...aro.org> wrote:
> > +Felipe
> >
> > On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
> > <oleksandr.savchenko@...com> wrote:
> >> From: Ruchika Kharwar <ruchika@...com>
> >>
> >> Ensure the Interrupt handling routine return IRQ_HANDLED vs
> >> IRQ_NONE.
> >
> > Why?
> >
> > By unconditionally returning IRQ_HANDLED, this patch will surely break
> > systems where the UART IRQ is shared with other platforms.
> >
> > I just noticed this patch when bisecting a related problem.  Why
> > wasn't this Cc'd to linux-omap where OMAP users might have been more
> > likely to see it?
> >
> > Greg, without a better justification in the changelog, I think this
> > patch should be dropped from tty-next.
> 
> Can you drop this from tty-next please?
> 
> The authors aren't responding (one of the ti.com addresses bounced)
> and this "fix" is most is not correct.

Yes, sorry, behind on my pending tty patch queue.  I'll try to get to it
this week.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/