linux-kernel - Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130827191623.GY3005@radagast>
Date:	Tue, 27 Aug 2013 14:16:23 -0500
From:	Felipe Balbi <balbi@...com>
To:	Peter Chen <peter.chen@...escale.com>
CC:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Felipe Balbi <balbi@...com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

On Mon, Aug 19, 2013 at 09:24:01AM +0800, Peter Chen wrote:
> On Sun, Aug 18, 2013 at 10:20:44PM +0200, Geert Uytterhoeven wrote:
> > If NO_DMA=y:
> > 
> > drivers/built-in.o: In function `dma_set_coherent_mask':
> > include/linux/dma-mapping.h:93: undefined reference to `dma_supported'
> > 
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > ---
> >  drivers/usb/chipidea/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> > index d1bd8ef..dbd5232 100644
> > --- a/drivers/usb/chipidea/Kconfig
> > +++ b/drivers/usb/chipidea/Kconfig
> > @@ -1,6 +1,6 @@
> >  config USB_CHIPIDEA
> >  	tristate "ChipIdea Highspeed Dual Role Controller"
> > -	depends on USB || USB_GADGET
> > +	depends on (USB || USB_GADGET) && HAS_DMA
> >  	help
> >  	  Say Y here if your system has a dual role high speed USB
> >  	  controller based on ChipIdea silicon IP. Currently, only the
> 
> I can't understand why the DMA can't be changed to fix this instead
> of changing every driver?

I'm with you. It'd be nicer to just provide empty stubs when !HAS_DMA

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)