linux-kernel - Re: [PATCH V5] gpio: New driver for LSI ZEVIO SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <521D0783.9000804@wwwdotorg.org>
Date:	Tue, 27 Aug 2013 14:09:39 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Fabian Vogt <fabian@...ter-vogt.de>
CC:	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
	linus.walleij@...aro.org, grant.likely@...aro.org,
	pawel.moll@....com, rob.herring@...xeda.com, mark.rutland@....com,
	ian.campbell@...rix.com
Subject: Re: [PATCH V5] gpio: New driver for LSI ZEVIO SoCs

On 08/26/2013 12:18 PM, Fabian Vogt wrote:
> This driver supports the GPIO controller found in LSI ZEVIO SoCs.
> It has been successfully tested on a TI nspire CX calculator.

What changed in v5 (or indeed any other versions?)

> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt

> +Zevio GPIO controller
> +
> +Required properties:
> +- compatible = "lsi,zevio-gpio"
> +- reg = <BASEADDR SIZE>

Perhaps this should say:

reg: Contains a single register specifier for the GPIO module's registers.

> +- #gpio-cells = <2>

This should describe what those cells are. For example perhaps:

#gpio-cells. Must be 2. The first cell is the GPIO number. The second
  cell is used to specify optional parameters:
  - bit 0 specifies polarity (0 for normal, 1 for inverted)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/