linux-kernel - Re: [PATCH v3 1/1 resend] i2c: rcar: modify I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Aug 2013 11:02:47 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Nguyen Viet Dung <nv-dung@...so.co.jp>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	kuninori.morimoto.gx@...esas.com
Subject: Re: [PATCH v3 1/1 resend] i2c: rcar: modify I2C driver

On Tue, Aug 27, 2013 at 04:55:22PM +0900, Nguyen Viet Dung wrote:
> This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2.
> 
> Signed-off-by: Nguyen Viet Dung <nv-dung@...so.co.jp>

Yes, this is much better. Only minor things...

> +	switch (priv->devtype) {
> +	default:
> +	case I2C_RCAR_H1:
> +		cdf_width = 2;
> +		break;
> +	case I2C_RCAR_H2:
> +		cdf_width = 3;
> +		break;
> +	}
> +

Please put the default case block at the end.

> @@ -632,6 +649,13 @@ static int rcar_i2c_probe(struct platform_device *pdev)
>  	bus_speed = 100000; /* default 100 kHz */
>  	if (pdata && pdata->bus_speed)
>  		bus_speed = pdata->bus_speed;
> +
> +	if (!pdev->id_entry) {
> +		dev_err(&pdev->dev, "no entry\n");
> +		return -ENODEV;
> +	}

This cannot happen. Since you have 'i2c-rcar' in the id_table, the
driver core will always match against the id_table and there is always a
driver_data defined.


> +	priv->devtype = pdev->id_entry->driver_data;

Basically the same, but please use

	platform_get_device_id(pdev)->driver_data;

Otherwise good!

Thanks,

   Wolfram

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)