linux-kernel - Re: [PATCH RESEND] HID: New hid-cp2112 driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1308281455350.4557@pobox.suse.cz>
Date:	Wed, 28 Aug 2013 14:57:56 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	David Barksdale <dbarksdale@...ogix.com>
Cc:	linux-kernel@...r.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH RESEND] HID: New hid-cp2112 driver.


[ adding Benjamin to CC ]

On Tue, 27 Aug 2013, David Barksdale wrote:

> This patch adds support for the Silicon Labs CP2112
> "Single-Chip HID USB to SMBus Master Bridge."
> 
> I wrote this to support a USB temperature and humidity
> sensor I've been working on. It's been tested by using
> SMBus byte-read, byte-data-read/write, and word-data-read
> transfer modes to talk to an I2C sensor. The other
> transfer modes have not been tested.
> 
> Signed-off-by: David Barksdale <dbarksdale@...ogix.com>
> 
> ---
>  drivers/hid/Kconfig      |   6 +
>  drivers/hid/Makefile     |   1 +
>  drivers/hid/hid-core.c   |   3 +
>  drivers/hid/hid-cp2112.c | 504 +++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 514 insertions(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 14ef6ab..1833948 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -175,6 +175,12 @@ config HID_PRODIKEYS
>  	  multimedia keyboard, but will lack support for the musical keyboard
>  	  and some additional multimedia keys.
>  
> +config HID_CP2112
> +	tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> +	depends on USB_HID
> +	---help---
> +	Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
> +

Hi David,

this is rather difficult to get by quickly looking at the code, so I'd 
like to have a slightly better overview of what the device really is.

Is it talking HID protocol on the SMBus? (if so, there is a hid-i2c 
transport driver for it already).
But I guess this is not really the case, as you seem to be using the USB 
HID functionality as well.

Thanks in advance for some more background.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/